Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Indications that required signoffs have been achieved #3016

Merged
merged 15 commits into from
Oct 19, 2023

Conversation

AMUZY
Copy link
Contributor

@AMUZY AMUZY commented Oct 16, 2023

In an attempt to fix the issue on the UI where there was no indication about about signoffs that have been achieved, I have made the changes in the UI to solve this issue.
Please view the changes in the images below :

DNDLrGucLMJfzUlQbcQpMylE

So now, for beside every required signoff, you will be able to know how many people have signed and how many haven't signed depending on the number of required signoffs from a particular role.

  • You get a checked icon followed by the users email (for those that have signed).
  • You will get an "Awaiting approval..." for the signoffs that haven't been achieved yet.

For further simplicity, the emails of those that have signed should not show? (if it isn't necessary for the signed users emails to show) so we have only the green check icon? @bhearsum @gabrielBusta . Please let me know in your review and I'd make the changes done.

Copy link
Contributor

@bhearsum bhearsum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally and visually this looks very nice! I have a few nits that nit to be addressed before this can be merged, but nothing major.

Nice work!

ui/package.json Outdated Show resolved Hide resolved
ui/src/components/SignoffSummary/index.jsx Outdated Show resolved Hide resolved
ui/src/components/SignoffSummary/index.jsx Show resolved Hide resolved
ui/src/components/SignoffSummary/index.jsx Outdated Show resolved Hide resolved
ui/src/components/SignoffSummary/index.jsx Outdated Show resolved Hide resolved
Copy link
Contributor

@bhearsum bhearsum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now - thank you so much!

@bhearsum bhearsum merged commit 6d46207 into mozilla-releng:main Oct 19, 2023
6 checks passed
@AMUZY
Copy link
Contributor Author

AMUZY commented Oct 19, 2023

I'm thrilled😊

@gabrielBusta
Copy link
Member

Thanks @AMUZY!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants