-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show Indications that required signoffs have been achieved #3016
Show Indications that required signoffs have been achieved #3016
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionally and visually this looks very nice! I have a few nits that nit to be addressed before this can be merged, but nothing major.
Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now - thank you so much!
I'm thrilled😊 |
Thanks @AMUZY! |
In an attempt to fix the issue on the UI where there was no indication about about signoffs that have been achieved, I have made the changes in the UI to solve this issue.
Please view the changes in the images below :
So now, for beside every required signoff, you will be able to know how many people have signed and how many haven't signed depending on the number of required signoffs from a particular role.
For further simplicity, the emails of those that have signed should not show? (if it isn't necessary for the signed users emails to show) so we have only the green check icon? @bhearsum @gabrielBusta . Please let me know in your review and I'd make the changes done.